Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIA-700: Drop desktop's native kapps library and use kotlinx serialization as replacement #3

Merged
merged 1 commit into from
Oct 16, 2023
Merged

PIA-700: Drop desktop's native kapps library and use kotlinx serialization as replacement #3

merged 1 commit into from
Oct 16, 2023

Conversation

kp-juan-docal
Copy link
Contributor

Summary

As per the title, we are dropping the kapps library in favor of kotlinx serialization and doing the localization association within the module.

Sanity Tests

  • Update the implementation on the client. Open the application. Confirm the list of regions is populated.
  • After the above. Pull down to refresh. Confirm it is updated.
  • After the above. Connect to any region using Wireguard. Confirm it connects successfully.
  • After the above. Connect to any region using OpenVpn. Confirm it connects successfully.

@kp-juan-docal kp-juan-docal self-assigned this Oct 16, 2023
kp-iva-nedeleva
kp-iva-nedeleva approved these changes Oct 16, 2023
View reviewed changes
Copy link

@kp-iva-nedeleva kp-iva-nedeleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kp-juan-docal kp-juan-docal merged commit e6df26d into master Oct 16, 2023
@kp-juan-docal kp-juan-docal deleted the juan.docal/PIA-700-drop-desktop-native-kapps-library-and-introduce-serialization branch October 16, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-iva-nedeleva kp-iva-nedeleva kp-iva-nedeleva approved these changes

Assignees

@kp-juan-docal kp-juan-docal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kp-juan-docal @kp-iva-nedeleva