Merged PR, removed SCSS warnings, added rows, columns, :user-valid, labels to groups and more #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a dropdown that contains an accordion within it, the accordion renders as a dropdown because the summary selector also selects the children of a dropdown element. This fixes that so it renders as expected.
```
<details class="dropdown">
<summary> Select a phase of matter... </summary>
<ul>
<li>
<details>
<summary> This is a dropdown option </summary>
<ul>
<li><label><input type="radio" name="phase" value="gas"> Gas </label></li>
<li><label><input type="radio" name="phase" value="plasma"> Plasma </label></li>
</ul>
</details>
</li>
</ul>
</details>
```
Mixed sass declarations
fix: Card in modal does not use modal styling
Add date to list of excluded input types.
fix: don't count hidden rows in table stripes
Update _loading.scss not to affect form elements itself
Fix several typos throughout the project
Fix details inside drop-down being rendered as dropdown
Update _tooltip.scss
Surpressing sass warnings and closing 1 & 11
…o 2, and added responsive .row, .col-*, and .offset-* classes, using display:gid, the same way bootsrap-5 is set up for the .row, .com-* and .offset* classes.
… enviroment. Added accordion javascript for slide effect. modified the notification scss, and added more demos.
…eader > h[1-6]` And added the border-color for dark theme on the article > header
Improve Code Rendering
… for tabs and not have it apply to other buttons within it.
Pull requests can push to main, so do not have the pull request workflow in here.
…t create an empty selector
…icle, and if the form would be between the header and footer tags. Modals with the size classes on the dialog were not sizing correctly when form was a child of the modal, and this has been corrected.
Modal sizes and styling with form child
…g modals when its within a modal.
Prevent the FileValidator's remove button from bubbling up and closing modals when its within a modal.
Textarea floating labels
…nd update the floating labels
Added other components I've created to the Readme
Fixes Accordion chevron padding picocss#653 Demo has been updated with new hamburger nav example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasnt sure if this was still maintained and added some helpful resourced I created, and merged a bunch of open pull requests that corrected some issues.
Heres my Fork and Heres an updated Demo