Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc suggestion from IRC #pico.sh @ libera.chat #67

Merged
merged 1 commit into from
Jan 8, 2024
Merged

doc suggestion from IRC #pico.sh @ libera.chat #67

merged 1 commit into from
Jan 8, 2024

Conversation

securepub
Copy link
Contributor

@securepub securepub commented Jan 8, 2024 •
edited
Loading 

[10:25am] pareidoliac: I have had no problem with the docs apart from the 
          minor detail that the "-> yourusername" should be "-> {username}-myproject" 
          in the https://pgs.sh/help#custom-domain section.
[10:25am] pareidoliac: thinking of making a PR to suggest that 
[10:29am] pareidoliac: also suggest mentioning the CSP policy pico.sh vs custom domain 
          in the https://pgs.sh/help#spa section 
[10:44am] erock: happy to accept PRs

doc suggestion from IRC #pico.sh @ libera.chat
5cb04d5 
[10:25am] pareidoliac: I have had problem with the docs apart from the minor detail that the "-> yourusername"
          should be "-> {username}-myproject" in the https://pgs.sh/help#custom-domain section.
[10:25am] pareidoliac: thinking of making a PR to suggest that
[10:29am] pareidoliac: also suggest mentioning the CSP policy pico.sh vs custom domain in the https://pgs.sh/help#spa section
[10:44am] erock: happy to accept PRs
@securepub securepub marked this pull request as ready for review January 8, 2024 20:06
@neurosnap neurosnap merged commit 85ad4b8 into picosh:main Jan 8, 2024
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neurosnap neurosnap neurosnap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@securepub @neurosnap