Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
\Picqer\Financials\Exact\Units
class was added in 2017 in ad75b5c whereas theUnit
(singular form) was added in 2019 (59dd598). Following the naming conventions it should be a singular form.PR Goal
This PR updates the
Units
class to become an extension ofUnit
and adds the deprecation trigger and annotation.Once/If we agree on if this deprecation style is acceptable for this project I can update the other duplicate classes as well. First feedback is much appreciated. Also see below about the other class duplications.
Additional info
There are multiple of these problems which can be discovered by running a bash command to find PHP files containing duplicate
@see
annotations in thesrc
folder.See all duplicate @see notations