Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 101 style #2

Open
wants to merge 158 commits into
base: master
Choose a base branch
from
Open

RFC 101 style #2

wants to merge 158 commits into from

Conversation

piegamesde
Copy link
Owner

No description provided.

Lucus16 and others added 30 commits April 6, 2023 12:20
To make more clear that one formats and the other one only checks
Tests mostly imported from Alejandra
- Disallow single-line if statements
- Handle multi-line conditions differently (indent instead of absorb)
- The (from) case needs to be improved
- Somehow it indents the comments *after* the statement now, no idea why or how to fix
The file was identical to diff/idioms_nixos_1 and therefore redundant.
Moreover, we need to also keep a look on the *really* big packages in there,
and Mozilla is a prime example.
Except when that item is another list or attribute set
This is nixos/modules/services/web-apps/nextcloud.nix, so that we have a
big NixOS module in our suite
from not form
There is now the choice whether to pull whitespace just before/at the start of a group
in or out. This allows to fix an outstanding issue with inherit statements, and is also
used in the bindings format
They now get expanded and indented more liberally, with some exceptions.
Things still look weird at places because of parentheses formatting.
With a couple of exceptions, multiline parentheses are now
forced to start on the next line.
@piegamesde piegamesde force-pushed the rfc101-style branch 2 times, most recently from dc93faa to 4144733 Compare February 28, 2024 10:47
Dunno too tired to properly describe them
@piegamesde piegamesde force-pushed the rfc101-style branch 2 times, most recently from 40d95dc to 19a377b Compare March 1, 2024 17:25
infinisil and others added 9 commits March 13, 2024 00:53
The web demo will be retired from this repo soon anyways, see NixOS#157

I believe it also relied on using Serokell's self-hosted action runners, which
we can't use anymore now that the repo has been transferred, so we use
the default ubuntu-latest instead.
The nixfmt-webdemo is moving to
https://github.com/serokell/nixfmt-website. Remove all code associated
with the webdemo, including the nixfmt-js distribution.
ci: remove deploy and fix after repo transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants