forked from NixOS/nixfmt
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 101 style #2
Open
piegamesde
wants to merge
158
commits into
master
Choose a base branch
from
rfc101-style
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make more clear that one formats and the other one only checks
Tests mostly imported from Alejandra
- Disallow single-line if statements - Handle multi-line conditions differently (indent instead of absorb)
- The (from) case needs to be improved - Somehow it indents the comments *after* the statement now, no idea why or how to fix
The file was identical to diff/idioms_nixos_1 and therefore redundant. Moreover, we need to also keep a look on the *really* big packages in there, and Mozilla is a prime example.
Except when that item is another list or attribute set
This is nixos/modules/services/web-apps/nextcloud.nix, so that we have a big NixOS module in our suite
from not form
There is now the choice whether to pull whitespace just before/at the start of a group in or out. This allows to fix an outstanding issue with inherit statements, and is also used in the bindings format
Fix typo in README.md
They now get expanded and indented more liberally, with some exceptions. Things still look weird at places because of parentheses formatting.
With a couple of exceptions, multiline parentheses are now forced to start on the next line.
There was some weird edge case involving long lines and "simple" arguments
piegamesde
force-pushed
the
rfc101-style
branch
2 times, most recently
from
February 28, 2024 10:47
dc93faa
to
4144733
Compare
Dunno too tired to properly describe them
piegamesde
force-pushed
the
rfc101-style
branch
2 times, most recently
from
March 1, 2024 17:25
40d95dc
to
19a377b
Compare
Create team document
readme: Add status note
The web demo will be retired from this repo soon anyways, see NixOS#157 I believe it also relied on using Serokell's self-hosted action runners, which we can't use anymore now that the repo has been transferred, so we use the default ubuntu-latest instead.
The nixfmt-webdemo is moving to https://github.com/serokell/nixfmt-website. Remove all code associated with the webdemo, including the nixfmt-js distribution.
ci: remove deploy and fix after repo transfer
Remove webdemo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.