REMIND/EDGE-T variable harmonization #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orichters
approved these changes
Aug 26, 2024
.buildlibrary
Outdated
| @@ -11,6 +11,7 @@ AcceptedNotes: | |||
| - Imports includes .* non-default packages. | |||
| - unable to verify current time | |||
| - checking installed package size | |||
| - no visible global function definition for ':=' | |||
There was a problem hiding this comment.
Please rather add @importFrom data.table := to reportCrossVariables.R, plotNashConvergence.R and calc_CES_marginals.R where it is currently missing.
And while you are at it, can you please adjust the unit of Expenditure|Transport|Fuel to billion US$2005/yr in this line such that we can close pik-piam/edgeTransport#268?
There was a problem hiding this comment.
Sure! I did not know, that you can use it with dplyr as well..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ES reporting unit notation from bn to billion as it is more compatible with other piam variables like billion US$2005/yr and currently imlemented in reporttransport. This PR is related to PR #361 in piam_interfaces
AND remove very old edge-transport reporting that was used ages ago and is not compatible with the new version