Better deletion of Famous Nodes. #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be better to call removeChild on the parent since that does some cleanup in the parent, and it also calls dismount of the child. What do you think?
…de onto some other node in a custom class that extends react-famonus Node.
| @@ -42,7 +42,7 @@ class Node extends React.Component { | |||
| } | |||
|
|
|||
| famousDelete() { | |||
| this._famousNode.dismount(); | |||
| this._famousNode.getParent().removeChild(this._famousNode); | |||
There was a problem hiding this comment.
@pilwon This throws if the node has no parent. Maybe we should check if the node has a parent first?
There was a problem hiding this comment.
@pilwon By the way, I've ben using react-famous on two projects. It's really nice (except for all the bugs in Famous itself right now)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thin this is better because it does cleanup inside the parent node as well.