Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes cell width not taking all space #694

Open
wants to merge 1 commit into
base: 1.6
Choose a base branch
from
Open

Fixes cell width not taking all space #694

wants to merge 1 commit into from

Conversation

mhgtlc
Copy link
Contributor

@mhgtlc mhgtlc commented Sep 17, 2024

Fixes #688

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@robertSt7
Copy link
Contributor

@mhgtlc Thanks for coming up with a solution. But I think when we remove this code then we will have this problem again, right?
#566

@robertSt7 robertSt7 self-assigned this Sep 20, 2024
@mhgtlc
Copy link
Contributor Author

mhgtlc commented Sep 20, 2024

@mhgtlc Thanks for coming up with a solution. But I think when we remove this code then we will have this problem again, right? #566

@robertSt7 probably yes, in this case we need another solution I guess

@kingjia90 kingjia90 changed the base branch from 1.5 to 1.6 October 1, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@robertSt7 robertSt7

Labels
Pimcore:ToDo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhgtlc @robertSt7 @wisconaut