Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix background for external transparent image #734

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix background for external transparent image #734

merged 1 commit into from
Nov 8, 2024

Conversation

mhgtlc
Copy link
Contributor

@mhgtlc mhgtlc commented Oct 28, 2024

For external image:
Screenshot 2024-10-28 at 12 06 26

when uploading a transparent image, it looks like:
Screenshot 2024-10-28 at 12 06 00

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mattamon mattamon self-assigned this Nov 8, 2024
mattamon
mattamon approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the fix!

@mattamon mattamon added this to the 1.6.2 milestone Nov 8, 2024
@mattamon mattamon merged commit cfb446e into pimcore:1.6 Nov 8, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattamon mattamon mattamon approved these changes

Assignees

@mattamon mattamon

Labels
Pimcore:ToDo
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mhgtlc @mattamon @wisconaut