Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doesn't add empty CATEGORIES if field empty in interactive mode #1301

Merged
merged 1 commit into from
Oct 19, 2023
Merged

doesn't add empty CATEGORIES if field empty in interactive mode #1301

merged 1 commit into from
Oct 19, 2023

Conversation

titibandit
Copy link
Contributor

fixes issue #1300

WhyNotHugo
WhyNotHugo requested changes Oct 19, 2023
View reviewed changes
khal/khalendar/event.py Outdated Show resolved Hide resolved
khal/khalendar/event.py Outdated Show resolved Hide resolved
@WhyNotHugo
Copy link
Member

I tested this with the following sequence (with ikhal):

  • Edit an event and add a category to it.
  • Check the file (it has CATEGORIES:test).
  • Edit the event again and remove the category.
  • CATEGORIES: is gone.

WhyNotHugo
WhyNotHugo approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhyNotHugo WhyNotHugo merged commit 0395b57 into pimutils:master Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhyNotHugo WhyNotHugo WhyNotHugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titibandit @WhyNotHugo