Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure urwid vesrion is 2.6.15 else issue #1357 #1358

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Make sure urwid vesrion is 2.6.15 else issue #1357 #1358

merged 3 commits into from
Aug 20, 2024

Conversation

gachikuku
Copy link
Contributor

Upgrading urwid fixes issue #1357.

@mschilli87
Copy link

Just wanted to confirm this fixes the issue for me as well.

WhyNotHugo
WhyNotHugo reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog for "not yet released" says "UPDATED REQUIREMENT urwid is now required >= 2.1.0". We ought to update that entry.

WhyNotHugo
WhyNotHugo approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhyNotHugo
Copy link
Member

Feel free to add yourself to AUTHORS.txt.

@WhyNotHugo WhyNotHugo merged commit 106e4d0 into pimutils:master Aug 20, 2024
7 checks passed
@WhyNotHugo
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhyNotHugo WhyNotHugo WhyNotHugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gachikuku @mschilli87 @WhyNotHugo