Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed Sized constraints for encoders #80

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented Jan 22, 2025

This allows the more liberal usage of non-sized and dyn objects of
ClauseDatabase. We introduce the AsDynClauseDatabase for placed where
we need to be able to create a dyn ClauseDatabase references. This
trait is automatically implemented for all Sized types and dyn
references, but cannot be automatically implemented for ?Sized types.

This allows the more liberal usage of non-sized and `dyn` objects of
ClauseDatabase. We introduce the `AsDynClauseDatabase` for placed where
we need to be able to create a `dyn ClauseDatabase` references. This
trait is automatically implemented for all `Sized` types and `dyn`
references, but cannot be automatically implemented for `?Sized` types.
@Dekker1 Dekker1 merged commit 8c00377 into pindakaashq:develop Jan 22, 2025
5 checks passed
@Dekker1 Dekker1 deleted the fix/unsized branch January 22, 2025 00:04
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (ff7ecf6) to head (8c00377).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
crates/pindakaas/src/helpers.rs 30.76% 9 Missing ⚠️
crates/pindakaas/src/lib.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
- Coverage    72.12%   72.07%   -0.06%     
===========================================
  Files           20       20              
  Lines         7355     7377      +22     
  Branches      7355     7377      +22     
===========================================
+ Hits          5305     5317      +12     
- Misses        1923     1933      +10     
  Partials       127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant