Add support for dataset load with multiple processes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daverigby
force-pushed
the
load_data_multi_process
branch
from
0bdf1df
to
f49407a
Compare
Combining dataset loading (--pinecone-dataset) and multiple processes
(--processes) does not currently work due to interactions between
multithreading used by google.cloud.storage to download dataset files,
and fork()ing done by locust to create multiple processes.
Fix this by only performing Dataset downloading in the parent process
when locust is first started ('init' event), and having the child
processes only read the already-downloaded dataset files later when
the test starts ('test_start' event). This also avoids any unnecessary
/ conflicting download of the same data multiple times.
daverigby
force-pushed
the
load_data_multi_process
branch
from
f49407a
to
85847c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Combining dataset loading (--pinecone-dataset) and multiple processes (--processes) does not currently work due to interactions between multithreading used by google.cloud.storage to download dataset files, and fork()ing done by locust to create multiple processes.
Solution
Fix this by only performing Dataset downloading in the parent process when locust is first started ('init' event), and having the child processes only read the already-downloaded dataset files later when the test starts ('test_start' event). This also avoids any unnecessary / conflicting download of the same data multiple times.
Type of Change
Test Plan
New integration test added.