pyarrow.jemalloc_set_decay_ms(): Ignore if jemalloc not present #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemalloc support is not always present in pyarrow distributions - for example pyarrow-v11 on macOS doesn't have it. As such, don't error if jemalloc_set_decay_ms() raises NotImplementedError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
jemalloc support is not always present in pyarrow distributions - for
example pyarrow-v11 on macOS doesn't have it. Attempting to call
jemalloc_set_decay_ms() raises an exception if support is not present.
Solution
Ignore any NotImplementedError exception raised by jemalloc_set_decay_ms().
Type of Change
Test Plan
Tested on macOS system where pyarrow does not have jemalloc support.