Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset Improvements #45

Closed
wants to merge 2 commits into from
Closed

Dataset Improvements #45

wants to merge 2 commits into from

Conversation

daverigby
Copy link
Collaborator

Couple of minor improvements to the Dataset class:

  • Perf: Speed up query sample selection
  • Dataset.load(): Additional logging

@daverigby
Perf: Speed up query sample selection
8941887 
Convert the vectors from pandas DataFrame to Python objects up-front
as it's expensive to iterate on DataFrame (query sampling must
iterate).
@daverigby
Dataset.load(): Additional logging
9426cf1
@daverigby daverigby closed this Feb 29, 2024
@daverigby daverigby deleted the dataset_improvements branch February 29, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daverigby