Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Type column to align 'Pinecone gRPC' correctly #49

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

daverigby
Copy link
Collaborator

Problem

The default width of the stats 'Type' column is 8 chars. That is too
small to fit the 'Pine gRPC' name without the columns becoming
unaligned:

Type     Name                               # reqs      # fails |    Avg     Min     Max    Med |   req/s  failures/s
--------|---------------------------------|-------|-------------|-------|-------|-------|-------|--------|-----------
Pine gRPC  Fetch                                   1     0(0.00%) |    185     185     185    185 |    0.23        0.00
Pine gRPC  Vector (Query only)                     3     0(0.00%) |    203     199     206    200 |    0.68        0.00
--------|---------------------------------|-------|-------------|-------|-------|-------|-------|--------|-----------
     Aggregated                             16     0(0.00%) |    227     182     782    190 |    3.64        0.00

Solution

Fix by expanding the size of the column to be based on the length of
the request type, and expanding 'Pine' -> 'Pinecone' to be more
explicit (now it fits).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

The default width of the stats 'Type' column is 8 chars. That is too
small to fit the 'Pine gRPC' name without the columns becoming
unaligned:

    Type     Name                               # reqs      # fails |    Avg     Min     Max    Med |   req/s  failures/s
    --------|---------------------------------|-------|-------------|-------|-------|-------|-------|--------|-----------
    Pine gRPC  Fetch                                   1     0(0.00%) |    185     185     185    185 |    0.23        0.00
    Pine gRPC  Vector (Query only)                     3     0(0.00%) |    203     199     206    200 |    0.68        0.00
    --------|---------------------------------|-------|-------------|-------|-------|-------|-------|--------|-----------
	     Aggregated                             16     0(0.00%) |    227     182     782    190 |    3.64        0.00

Fix by expanding the size of the column to be based on the length of
the request type, and expanding 'Pine' -> 'Pinecone' to be more
explicit (now it fits).
@daverigby daverigby merged commit 53bd554 into main Feb 29, 2024
7 checks passed
@daverigby daverigby deleted the tidy_name branch February 29, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant