[spruce] Bump @pinecone-database version to support global control plane #29
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschwabco
suggested changes
Dec 20, 2023
| if (!indexExists) { | ||
| await pinecone.createIndex({ | ||
| name: indexName, | ||
| dimension: 1536, | ||
| spec: { | ||
| serverless: { | ||
| region: 'us-west-2', |
There was a problem hiding this comment.
I think this shouldn't be hard coded, but set in .env
| spec: { | ||
| serverless: { | ||
| region: 'us-west-2', | ||
| cloud: 'aws', |
| PINECONE_API_KEY= | ||
| PINECONE_ENVIRONMENT= |
There was a problem hiding this comment.
Not sure why we're removing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've been working to support the new global control plane service in the Pinecone clients. We need to update our sample apps to migrate to the new client versions, and update associated code paths as needed.
Solution
@pinecone-database/pineconedependency to use the newspruceDevversion of the client:^1.1.2-spruceDev.20231214000822.pinecone.tsandseed.tsto handle the new object response fromlistIndexes().seed.tsto pass the proper config object shape tocreateIndex().For now, I've created a spruce branch to merge this into as we probably don't want to release sample apps that aren't aligned with what's available publicly.
Type of Change
Test Plan
Run the playwright test suite and run the application locally: