Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetHealthFeedback RPC #1239

Merged
merged 5 commits into from
May 13, 2024

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Apr 8, 2024

I wonder if this is an acceptable approach...
Ref: tikv/tikv#16297

@ti-chi-bot ti-chi-bot bot added the size/XXL label Apr 25, 2024
@MyonKeminta MyonKeminta marked this pull request as ready for review May 13, 2024 09:12
@ti-chi-bot ti-chi-bot bot requested review from cfzjywxk and YuJuncen May 13, 2024 09:12
@MyonKeminta MyonKeminta marked this pull request as draft May 13, 2024 09:20
@MyonKeminta MyonKeminta marked this pull request as ready for review May 13, 2024 09:20
@MyonKeminta MyonKeminta changed the title Add RequestHealthFeedback request to batch commands Add GetHealthFeedback RPC May 13, 2024
Copy link

ti-chi-bot bot commented May 13, 2024

@crazycs520: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-13 09:48:51.029722502 +0000 UTC m=+1473884.786858068: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot added the approved label May 13, 2024
@cfzjywxk
Copy link
Contributor

/merge

@cfzjywxk cfzjywxk merged commit d929755 into pingcap:master May 13, 2024
4 of 5 checks passed
@MyonKeminta MyonKeminta deleted the m/request-health-feedback branch May 13, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants