Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate spanz module from tiflow #966

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

wlwilliamx
Copy link
Collaborator

@wlwilliamx wlwilliamx commented Feb 6, 2025

What problem does this PR solve?

Issue Number: close #965

What is changed and how it works?

This PR migrates the spanz module from the legacy tiflow repository to ticdc.

Changes:

  • Copied spanz/ directory from tiflow@[3703b18c6] (including the implementation of monitoring tidb_ddl_history table)
  • Refactored imports to use ticdc dependencies
  • Verified integration with CDC components

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

NO.

Do you need to update user documentation, design documentation or monitoring documentation?

NO.

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 6, 2025
@wlwilliamx wlwilliamx requested a review from lidezhu February 6, 2025 10:26
pkg/spanz/span.go Outdated Show resolved Hide resolved
@wlwilliamx
Copy link
Collaborator Author

/retest

@wlwilliamx wlwilliamx requested a review from lidezhu February 7, 2025 09:32
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 7, 2025
Copy link

ti-chi-bot bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-07 09:35:46.502556018 +0000 UTC m=+3588.898778079: ☑️ agreed by lidezhu.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 7, 2025
@ti-chi-bot ti-chi-bot bot merged commit 7437b16 into pingcap:master Feb 7, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate spanz folder from tiflow to ticdc
2 participants