Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify extra store labels by param --labels (#420) (release-8.5) #421

Open
wants to merge 1 commit into
base: raftstore-proxy-8.5
Choose a base branch
from

Conversation

JaySon-Huang
Copy link
Collaborator

@JaySon-Huang JaySon-Huang commented Feb 11, 2025

cherry-pick of #420

ref pingcap/tiflash#9750

  • Remove param --engine-role-label
  • Specify extra store labels by param --labels
    • If there are duplicated key in server.labels and --labels, use the one in server.labels

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:


Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note


ref pingcap/tiflash#9750

* Remove param `--engine-role-label`
* Specify extra store labels by param `--labels`
  * If there are duplicated key in `server.labels` and `--labels`, use the one in `server.labels`

Signed-off-by: JaySon-Huang <[email protected]>
Copy link

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jayson-huang, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL label Feb 11, 2025
@JaySon-Huang
Copy link
Collaborator Author

/test pull-unit-test

1 similar comment
@JaySon-Huang
Copy link
Collaborator Author

/test pull-unit-test

@JaySon-Huang
Copy link
Collaborator Author

/test build-check

Copy link

ti-chi-bot bot commented Feb 11, 2025

@JaySon-Huang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant