Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pd): rename underlying resource names #5983

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

liubog2008
Copy link
Member

Change {cluster}-{group} to {group}-{component} as the "name space" of underlying native resources.

This change fixes two conflicts.

cluster1="aaa-xxx"
group1="bbb"

cluster2="aaa"
group2="xxx-bbb"

and

tidbgroup="bbb"
tikvgroup="bbb"

@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc self-requested a review December 18, 2024 09:33
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 2.47350% with 276 lines in your changes missing coverage. Please review.

Project coverage is 19.69%. Comparing base (83f5ff4) to head (f519462).

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #5983      +/-   ##
==========================================
- Coverage   20.00%   19.69%   -0.32%     
==========================================
  Files         151      151              
  Lines       10305    10461     +156     
==========================================
- Hits         2062     2060       -2     
- Misses       8031     8189     +158     
  Partials      212      212              
Flag Coverage Δ
unittest 19.69% <2.47%> (-0.32%) ⬇️

@csuzhangxc csuzhangxc merged commit 5c8cd6a into pingcap:v2 Dec 18, 2024
6 of 13 checks passed
@liubog2008 liubog2008 added the v2 for operator v2 label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants