Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cluster/member/store ID for Pod and PVC #6049

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Jan 23, 2025

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 74.52830% with 27 lines in your changes missing coverage. Please review.

Project coverage is 69.95%. Comparing base (a90bc31) to head (4e90bc6).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6049      +/-   ##
==============================================
- Coverage       69.98%   69.95%   -0.04%     
==============================================
  Files             153      153              
  Lines            9530     9596      +66     
==============================================
+ Hits             6670     6713      +43     
- Misses           2860     2883      +23     
Flag Coverage Δ
unittest 69.95% <74.52%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-v2

@csuzhangxc csuzhangxc added the v2 for operator v2 label Jan 23, 2025
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-v2

Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2025

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgksgf
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit c75ea80 into pingcap:feature/v2 Jan 23, 2025
6 of 7 checks passed
@csuzhangxc csuzhangxc deleted the id-label branch January 23, 2025 03:54
liubog2008 pushed a commit to liubog2008/tidb-operator that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants