Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): use openapi v3 to generate client #6056

Merged
merged 2 commits into from
Feb 6, 2025
Merged

feat(client): use openapi v3 to generate client #6056

merged 2 commits into from
Feb 6, 2025

Conversation

liubog2008
Copy link
Member

@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 February 5, 2025 09:39
@ti-chi-bot ti-chi-bot bot added the size/XXL label Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (469992a) to head (003526a).

Additional details and impacted files 
@@              Coverage Diff               @@
##           feature/v2    #6056      +/-   ##
==============================================
- Coverage       69.74%   69.41%   -0.34%     
==============================================
  Files             153      153              
  Lines            9638     9684      +46     
==============================================
  Hits             6722     6722              
- Misses           2916     2962      +46
Flag Coverage Δ
unittest 69.41% <0.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@liubog2008
fix tidy
003526a 
Signed-off-by: liubo02 <[email protected]>
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@liubog2008 liubog2008 added the v2 for operator v2 label Feb 5, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2025

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fgksgf
Copy link
Member

fgksgf commented Feb 6, 2025

/approve

1 similar comment
@liubog2008
Copy link
Member Author

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgksgf, liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 6, 2025
@liubog2008 liubog2008 merged commit c6138e2 into pingcap:feature/v2 Feb 6, 2025
7 of 8 checks passed
liubog2008 added a commit to liubog2008/tidb-operator that referenced this pull request Feb 7, 2025
@liubog2008
feat(client): use openapi v3 to generate client (pingcap#6056)
6d65a99 
* feat(client): use openapi v3 to generate client

Signed-off-by: liubo02 <[email protected]>

* fix tidy

Signed-off-by: liubo02 <[email protected]>

---------

Signed-off-by: liubo02 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgksgf fgksgf fgksgf approved these changes

@howardlau1999 howardlau1999 Awaiting requested review from howardlau1999

Assignees
No one assigned
Labels
approved size/XXL v2 for operator v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liubog2008 @codecov-commenter @fgksgf