Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog-filter: add VIEW related type #405

Merged
merged 1 commit into from
Dec 30, 2020
Merged

binlog-filter: add VIEW related type #405

merged 1 commit into from
Dec 30, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

DM is going to support sync VIEW statements in pingcap/dm#1310, so add VIEW related type in binlog filter

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Side effects

Related changes

@lance6716 lance6716 mentioned this pull request Nov 28, 2020
Open
@kennytm kennytm changed the title filter: add VIEW related type binlog-filter: add VIEW related type Nov 28, 2020
csuzhangxc
csuzhangxc reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Collaborator Author

PTAL @lichunzhu @3pointer

lichunzhu
lichunzhu approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit a482225 into pingcap:master Dec 30, 2020
@lance6716 lance6716 deleted the support-view branch December 30, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @csuzhangxc @lichunzhu