br: pipeline wait tiflash synced (#43726) #45018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
ti-chi-bot
added
release-note
ti-chi-bot
bot
added
release-note
Leavrth
approved these changes
Jun 28, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
3pointer
approved these changes
Aug 15, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
12 tasks
|
/retest |
2 similar comments
|
/retest |
|
/retest |
ti-chi-bot
added
the
cherry-pick-approved
|
/retest |
1 similar comment
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45018 +/- ##
================================================
Coverage ? 73.6530%
================================================
Files ? 1083
Lines ? 347699
Branches ? 0
================================================
Hits ? 256091
Misses ? 75162
Partials ? 16446 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #43726
What problem does this PR solve?
Issue Number: close #43828
Problem Summary:
Currently if we restore to a cluster that has tiflash replicas. BR only send ingest command to leader and doesn't guarantee learner(tiflash reploica) ready to serve when restore finished. in some worst cases the lag between leader and learner may take hours.
What is changed and how it works?
This PR add a config
wait-tiflash-readyto pipeline wait tiflash replica ready to serve when restore finished.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.