Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: distinguish the source of join hint information (#41440) #45642

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #41440

What problem does this PR solve?

Issue Number: ref #36600

Problem Summary:
distinguish the source of join hint information

What is changed and how it works?

  1. add the variable "tidb_opt_advanced_join_hint"
  2. When we try to build the join node in the plan-builder phase, we keep the hint information from the join's children. Not merge them all to the join node. Because, in the join reorder phase, we will split the join node and the join hint information will be lost.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot requested a review from a team as a code owner July 28, 2023 04:39
@ti-chi-bot ti-chi-bot added epic/hint release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 28, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 28, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 28, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-28 04:41:31.487291379 +0000 UTC m=+502234.081822366: ☑️ agreed by qw4990.
  • 2023-07-28 05:07:46.462488535 +0000 UTC m=+503809.057019523: ☑️ agreed by hawkingrei.

@qw4990
Copy link
Contributor

qw4990 commented Jul 28, 2023

/test build

@tiprow
Copy link

tiprow bot commented Jul 28, 2023

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@65f6531). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45642   +/-   ##
================================================
  Coverage               ?   73.6899%           
================================================
  Files                  ?       1081           
  Lines                  ?     346928           
  Branches               ?          0           
================================================
  Hits                   ?     255651           
  Misses                 ?      74872           
  Partials               ?      16405           

@qw4990
Copy link
Contributor

qw4990 commented Jul 28, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 28, 2023

@qw4990: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 230b5ff into pingcap:release-6.5 Jul 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. epic/hint lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants