br: refactor br cli backoff logic

[Tristan1900]

What problem does this PR solve?

Issue Number: close #54643

Problem Summary:

Refactor the BR CLI backoff retry logic to make is more simplified and extendable in future.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

NA

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[sre-bot]

All committers have signed the CLA.

[tiprow]

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Tristan1900]

tests to be fixed
also pending on #54596

[codecov]

Codecov Report

Attention: Patch coverage is 82.64984% with 55 lines in your changes missing coverage. Please review.

Project coverage is 57.4947%. Comparing base (1c386db) to head (33fa670).
Report is 136 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54644         +/-   ##
=================================================
- Coverage   73.3473%   57.4947%   -15.8527%     
=================================================
  Files          1638       1788        +150     
  Lines        453782     653387     +199605     
=================================================
+ Hits         332837     375663      +42826     
- Misses       100556     252502     +151946     
- Partials      20389      25222       +4833     

Flag	Coverage Δ
integration	39.3890% <72.9299%> (?)
unit	72.5221% <76.3406%> (-0.0396%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <100.0000%> (ø)
parser	∅ <ø> (∅)
br	63.2640% <82.4840%> (+17.2841%)	⬆️

[YuJuncen]

rest lgtm

[YuJuncen]

Could you replace this constructor with functional options or builder pattern?

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YuJuncen
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• br/OWNERS [YuJuncen]
• dumpling/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-28 10:15:47.880664025 +0000 UTC m=+258460.719819570: ☑️ agreed by YuJuncen.

[ti-chi-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.