Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix region split failure due to empty split key #56344

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

SonglinLife
Copy link
Contributor

@SonglinLife SonglinLife commented Sep 26, 2024

What problem does this PR solve?

when tikv region has empty endKey, the br split region will failed due to empty key

Issue Number: close #56228

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Sep 26, 2024

Welcome @SonglinLife!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 26, 2024
Copy link

ti-chi-bot bot commented Sep 26, 2024

Hi @SonglinLife. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Sep 26, 2024

Hi @SonglinLife. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 26, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.1034%. Comparing base (01797cb) to head (d5daab5).
Report is 41 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56344        +/-   ##
================================================
+ Coverage   73.4215%   77.1034%   +3.6819%     
================================================
  Files          1619       1649        +30     
  Lines        446764     465996     +19232     
================================================
+ Hits         328021     359299     +31278     
+ Misses        98638      85184     -13454     
- Partials      20105      21513      +1408     
Flag Coverage Δ
integration 53.6130% <0.0000%> (?)
unit 73.5271% <0.0000%> (+1.0211%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2242% <0.0000%> (+17.7014%) ⬆️

@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-tests-checked labels Sep 27, 2024
Copy link

ti-chi-bot bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2024
Copy link

ti-chi-bot bot commented Sep 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-27 01:58:24.951243733 +0000 UTC m=+1790374.691667673: ☑️ agreed by lance6716.
  • 2024-09-29 06:59:48.867384697 +0000 UTC m=+165344.287597710: ☑️ agreed by Leavrth.

@lance6716
Copy link
Contributor

/check-issue-triage-complete

@lance6716
Copy link
Contributor

/retest

@hawkingrei
Copy link
Member

/ok-to-test

@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit a168176 into pingcap:master Sep 30, 2024
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants