executor: fix data inconsistency after load data ... replace into ... (#56415)
#56505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
release-note
13 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/XXL
ti-chi-bot
bot
added
size/XS
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #56505 +/- ##
================================================
Coverage ? 73.6274%
================================================
Files ? 1097
Lines ? 352939
Branches ? 0
================================================
Hits ? 259860
Misses ? 76357
Partials ? 16722 |
ti-chi-bot
bot
added
cherry-pick-approved
Signed-off-by: Yang Keao <[email protected]>
ti-chi-bot
bot
added
size/M
YangKeao
approved these changes
Nov 13, 2024
| @@ -4291,3 +4291,37 @@ func TestHandleColumnWithOnUpdateCurrentTimestamp(t *testing.T) { | |||
| tk.MustExec("update t force index(primary) set b = 10 where a = '2023-06-11 10:00:00'") | |||
| tk.MustExec("admin check table t") | |||
| } | |||
|
|
|||
| func TestFix56408(t *testing.T) { | |||
There was a problem hiding this comment.
@fzzf678 PTAL. I added the test.
It adds two testCase to cover the case that a duplicated rows is loaded in a new query.
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
fzzf678
approved these changes
Nov 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzzf678, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #56415
What problem does this PR solve?
Issue Number: close #56408
Problem Summary:
What changed and how does it work?
The reason is the bool flag returned by
removeRowwas not rightly handled inhandleDuplicateKey.If we load a existed row,
removeRowwill return (true, nil),handleDuplicateKeyshould also return (true, nil)Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.