br: cancel context when timer stop (#56948) #57007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
ok-to-test
13 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Signed-off-by: Jianjun Liao <[email protected]>
ti-chi-bot
bot
added
size/S
Leavrth
approved these changes
Oct 31, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
BornChanger
approved these changes
Oct 31, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
retest |
|
/retest |
1 similar comment
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #57007 +/- ##
================================================
Coverage ? 73.6198%
================================================
Files ? 1097
Lines ? 352943
Branches ? 0
================================================
Hits ? 259836
Misses ? 76385
Partials ? 16722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #56948
What problem does this PR solve?
Issue Number: ref #53480
Problem Summary:
the context will leak because it is not cancelled.
What changed and how does it work?
cancel the context
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.