-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privilege: handle username with "@" correctly for role(RBAC) related code #59739
base: master
Are you sure you want to change the base?
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59739 +/- ##
================================================
+ Coverage 72.9611% 73.3837% +0.4225%
================================================
Files 1697 1698 +1
Lines 468962 469036 +74
================================================
+ Hits 342160 344196 +2036
+ Misses 105734 103774 -1960
+ Partials 21068 21066 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev2 |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #59552
Problem Summary:
What changed and how does it work?
The old code use key = username + "@" + host, and also split by "@" to get back the username.
This is not stable enough when the username itself contains "@"
Change key from username + "@" + host to {username, host} struct makes the code more robust.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.