-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: 'alter user' requires 'CREATE USER' privilege in most cases #59756
base: master
Are you sure you want to change the base?
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59756 +/- ##
================================================
+ Coverage 72.9647% 73.3737% +0.4090%
================================================
Files 1697 1697
Lines 468950 469432 +482
================================================
+ Hits 342168 344440 +2272
+ Misses 105711 103933 -1778
+ Partials 21071 21059 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Please add the description for this PR, the rest LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #59677
Problem Summary:
What changed and how does it work?
In most cases, 'alter user' statement requires 'CREATE USER' privilege.
Before this fix, if a user 'alter user' for himself, there is no privilege check.
But that should be very limited cases.
Tested with mysql, even "alter user current_user() comment 'xxx'" requires privilege check.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.