[#11982] Math.round to long maxValue

pinpoint-apm · Jan 23, 2025 · d6cbe0c · d6cbe0c
1 parent ccae72c
commit d6cbe0c
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 25 deletions.
diff --git a/web-frontend/src/main/v3/packages/ui/src/components/URL/summary/UrlSummaryColumns.tsx b/web-frontend/src/main/v3/packages/ui/src/components/URL/summary/UrlSummaryColumns.tsx
@@ -152,7 +152,7 @@ export const summaryColumns = ({
     accessorKey: 'chart',
     header: 'Volume',
     meta: {
-      headerClassName: 'w-40 text-sm font-medium text-center',
+      headerClassName: 'w-52 text-sm font-medium text-center',
       cellClassName: 'text-[-webkit-right]',
     },
     cell: (props) => {

diff --git a/web-frontend/src/main/v3/packages/ui/src/components/common/MiniChart.tsx b/web-frontend/src/main/v3/packages/ui/src/components/common/MiniChart.tsx
@@ -1,37 +1,38 @@
 import { Chart } from '@pinpoint-fe/ui/constants';
 import { ComposedChart, ReferenceLine } from 'recharts';
 import { useRechart } from '../ReChart/useRechart';
+import { ChartContainer } from '../ui';
 
 export interface MiniChart {
   chart: Chart;
 }
 
 export const MiniChart = ({ chart }: MiniChart) => {
-  const { data, maxValue, renderChartChildComponents } = useRechart(chart);
+  const { data, chartConfig, maxValue, renderChartChildComponents } = useRechart(chart);
 
   return (
-    <ComposedChart
-      width={128}
-      height={40}
-      data={data}
-      margin={{
-        top: 6,
-        right: 30,
-        bottom: 6,
-        left: 2,
-      }}
-    >
-      {data?.length && maxValue > -1 && (
-        <ReferenceLine
-          y={maxValue}
-          stroke="black"
-          strokeDasharray="3 3"
-          position="middle"
-          label={{ position: 'right', value: maxValue }}
-          ifOverflow="extendDomain"
-        />
-      )}
-      {renderChartChildComponents()}
-    </ComposedChart>
+    <ChartContainer config={chartConfig} className="w-full h-[40px]">
+      <ComposedChart
+        data={data}
+        margin={{
+          top: 6,
+          right: 60,
+          bottom: 6,
+          left: 2,
+        }}
+      >
+        {data?.length && maxValue > -1 && (
+          <ReferenceLine
+            y={maxValue}
+            stroke="black"
+            strokeDasharray="3 3"
+            position="middle"
+            label={{ position: 'right', value: Math.round(maxValue * 100) / 100 }}
+            ifOverflow="extendDomain"
+          />
+        )}
+        {renderChartChildComponents()}
+      </ComposedChart>
+    </ChartContainer>
   );
 };