Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10882] Add server map module based on redis-timeseries #11850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions collector/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,12 @@
<artifactId>jakarta.annotation-api</artifactId>
</dependency>


<dependency>
<groupId>com.navercorp.pinpoint</groupId>
<artifactId>pinpoint-redis-timeseries</artifactId>
<version>3.1.0-SNAPSHOT</version>
</dependency>
</dependencies>

<build>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.navercorp.pinpoint.collector;


import com.navercorp.pinpoint.collector.applicationmap.ApplicationMapModule;
import com.navercorp.pinpoint.collector.config.ClusterModule;
import com.navercorp.pinpoint.collector.config.CollectorCommonConfiguration;
import com.navercorp.pinpoint.collector.config.CollectorConfiguration;
Expand Down Expand Up @@ -38,6 +39,7 @@
RealtimeCollectorModule.class,

CollectorPinpointIdConfiguration.class,
ApplicationMapModule.class,
})
@ComponentScan(basePackages = {
"com.navercorp.pinpoint.collector.handler",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/*
* Copyright 2024 NAVER Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.navercorp.pinpoint.collector.applicationmap;

import org.springframework.context.annotation.ComponentScan;
import org.springframework.context.annotation.Configuration;

/**
* @author intr3p1d
*/
@Configuration(proxyBeanMethods = false)
@ComponentScan(basePackages = {
"com.navercorp.pinpoint.collector.applicationmap",
"com.navercorp.pinpoint.collector.applicationmap.dao",
"com.navercorp.pinpoint.collector.applicationmap.redis",
"com.navercorp.pinpoint.collector.applicationmap.service",
})
public class ApplicationMapModule {

Check warning on line 31 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/ApplicationMapModule.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/ApplicationMapModule.java#L31

Added line #L31 was not covered by tests
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/*
* Copyright 2024 NAVER Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.navercorp.pinpoint.collector.applicationmap.dao;

import com.navercorp.pinpoint.collector.dao.CachedStatisticsDao;
import com.navercorp.pinpoint.common.trace.ServiceType;

/**
* @author intr3p1d
*/
public interface InboundDao extends CachedStatisticsDao {
// src -> dest
// inbound (rowKey dest <- columnName src)
// outbound (rowKey src -> columnName dest)
void update(
long requestTime,
int srcServiceId, String srcApplicationName, ServiceType srcApplicationType,
int destServiceId, String destApplicationName, ServiceType destApplicationType,
String srcHost, int elapsed, boolean isError
);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/*
* Copyright 2024 NAVER Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.navercorp.pinpoint.collector.applicationmap.dao;

import com.navercorp.pinpoint.collector.dao.CachedStatisticsDao;
import com.navercorp.pinpoint.common.trace.ServiceType;

/**
* @author intr3p1d
*/
public interface OutboundDao extends CachedStatisticsDao {
// src -> dest
// inbound (rowKey dest <- columnName src)
// outbound (rowKey src -> columnName dest)
void update(
long requestTime,
int srcServiceId, String srcApplicationName, ServiceType srcApplicationType,
int destServiceId, String destApplicationName, ServiceType destApplicationType,
String srcHost, int elapsed, boolean isError
);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/*
* Copyright 2024 NAVER Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.navercorp.pinpoint.collector.applicationmap.dao;


import com.navercorp.pinpoint.collector.dao.CachedStatisticsDao;
import com.navercorp.pinpoint.common.trace.ServiceType;

/**
* @author intr3p1d
*/
public interface SelfDao extends CachedStatisticsDao {
void received(long requestTime, int serviceId, String applicationName, ServiceType applicationType, int elapsed, boolean isError);
void updatePing(long requestTime, int serviceId, String applicationName, ServiceType applicationType, int elapsed, boolean isError);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
/*
* Copyright 2024 NAVER Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.navercorp.pinpoint.collector.applicationmap.redis;

import com.navercorp.pinpoint.collector.applicationmap.dao.InboundDao;
import com.navercorp.pinpoint.collector.applicationmap.redis.schema.ApplicationMapTable;
import com.navercorp.pinpoint.collector.applicationmap.redis.schema.TimeSeriesKey;
import com.navercorp.pinpoint.collector.applicationmap.redis.schema.TimeSeriesValue;
import com.navercorp.pinpoint.collector.dao.hbase.IgnoreStatFilter;
import com.navercorp.pinpoint.collector.dao.hbase.statistics.MapLinkConfiguration;
import com.navercorp.pinpoint.collector.applicationmap.redis.statistics.RedisBulkWriter;
import com.navercorp.pinpoint.common.server.util.ApplicationMapStatisticsUtils;
import com.navercorp.pinpoint.common.trace.HistogramSchema;
import com.navercorp.pinpoint.common.trace.ServiceType;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.stereotype.Repository;

import java.util.Objects;

/**
* @author intr3p1d
*/
@Repository
public class RedisInboundDao implements InboundDao {

private final Logger logger = LogManager.getLogger(this.getClass());

Check warning on line 41 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L41

Added line #L41 was not covered by tests

private final IgnoreStatFilter ignoreStatFilter;
private final RedisBulkWriter bulkWriter;
private final MapLinkConfiguration mapLinkConfiguration;

public RedisInboundDao(
MapLinkConfiguration mapLinkConfiguration,
IgnoreStatFilter ignoreStatFilter,
@Qualifier("inboundBulkWriter") RedisBulkWriter bulkWriter
) {
this.mapLinkConfiguration = Objects.requireNonNull(mapLinkConfiguration, "mapLinkConfiguration");
this.ignoreStatFilter = Objects.requireNonNull(ignoreStatFilter, "ignoreStatFilter");
this.bulkWriter = Objects.requireNonNull(bulkWriter, "inboundBulkWriter");
}

Check warning on line 55 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L51-L55

Added lines #L51 - L55 were not covered by tests


@Override
public void update(
long requestTime,
int srcServiceId, String srcApplicationName, ServiceType srcApplicationType,
int destServiceId, String destApplicationName, ServiceType destApplicationType,
String srcHost, int elapsed, boolean isError
) {
Objects.requireNonNull(srcApplicationName, "srcApplicationName");
Objects.requireNonNull(destApplicationName, "destApplicationName");

Check warning on line 66 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L65-L66

Added lines #L65 - L66 were not covered by tests

if (logger.isDebugEnabled()) {
logger.debug("[Inbound] {} {}({}) <- {} {}({})[{}]",
destServiceId, destApplicationName, destApplicationType,
srcServiceId, srcApplicationName, srcApplicationType, srcHost

Check warning on line 71 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L69-L71

Added lines #L69 - L71 were not covered by tests
);
}

if (ignoreStatFilter.filter(srcApplicationType, srcHost)) {
logger.debug("[Ignore-Inbound] {} {}({}) <- {} {}({})[{}]",
destServiceId, destApplicationName, destApplicationType,
srcServiceId, srcApplicationName, srcApplicationType, srcHost

Check warning on line 78 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L76-L78

Added lines #L76 - L78 were not covered by tests
);
return;

Check warning on line 80 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L80

Added line #L80 was not covered by tests
}

final short srcSlotNumber = ApplicationMapStatisticsUtils.getSlotNumber(srcApplicationType, elapsed, isError);
HistogramSchema histogramSchema = srcApplicationType.getHistogramSchema();

Check warning on line 84 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L83-L84

Added lines #L83 - L84 were not covered by tests

// for inbound, main is destination
// and sub is source
final TimeSeriesKey applicationTypeKey = new TimeSeriesKey(

Check warning on line 88 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L88

Added line #L88 was not covered by tests
ApplicationMapTable.Inbound, "tenantId",
destServiceId, destApplicationName, destApplicationType.getCode(),
srcServiceId, srcApplicationName, srcApplicationType.getCode(),

Check warning on line 91 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L90-L91

Added lines #L90 - L91 were not covered by tests
srcSlotNumber
);
TimeSeriesValue addOne = new TimeSeriesValue(requestTime);
this.bulkWriter.increment(applicationTypeKey, addOne);

Check warning on line 95 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L94-L95

Added lines #L94 - L95 were not covered by tests

if (mapLinkConfiguration.isEnableAvg()) {
final TimeSeriesKey sumStatKey = new TimeSeriesKey(

Check warning on line 98 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L98

Added line #L98 was not covered by tests
ApplicationMapTable.Inbound, "tenantId",
destServiceId, destApplicationName, destApplicationType.getCode(),
srcServiceId, srcApplicationName, srcApplicationType.getCode(),
histogramSchema.getSumStatSlot().getSlotTime()

Check warning on line 102 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L100-L102

Added lines #L100 - L102 were not covered by tests
);
final TimeSeriesValue sumValue = new TimeSeriesValue(requestTime);
this.bulkWriter.increment(sumStatKey, sumValue, elapsed);

Check warning on line 105 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L104-L105

Added lines #L104 - L105 were not covered by tests
}
if (mapLinkConfiguration.isEnableMax()) {
final TimeSeriesKey maxStatKey = new TimeSeriesKey(

Check warning on line 108 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L108

Added line #L108 was not covered by tests
ApplicationMapTable.Inbound, "tenantId",
destServiceId, destApplicationName, destApplicationType.getCode(),
srcServiceId, srcApplicationName, srcApplicationType.getCode(),
histogramSchema.getMaxStatSlot().getSlotTime()

Check warning on line 112 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L110-L112

Added lines #L110 - L112 were not covered by tests
);
final TimeSeriesValue maxValue = new TimeSeriesValue(requestTime);
this.bulkWriter.updateMax(maxStatKey, maxValue, elapsed);

Check warning on line 115 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L114-L115

Added lines #L114 - L115 were not covered by tests
}

}

Check warning on line 118 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L118

Added line #L118 was not covered by tests

@Override
public void flushLink() {
this.bulkWriter.flushLink();
}

Check warning on line 123 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L122-L123

Added lines #L122 - L123 were not covered by tests

@Override
public void flushAvgMax() {
this.bulkWriter.flushAvgMax();
}

Check warning on line 128 in collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java

View check run for this annotation

Codecov / codecov/patch

collector/src/main/java/com/navercorp/pinpoint/collector/applicationmap/redis/RedisInboundDao.java#L127-L128

Added lines #L127 - L128 were not covered by tests

}
Loading