Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11971] Extract micrometer module #11972

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jan 17, 2025

No description provided.

@emeroad emeroad added this to the 3.1.0 milestone Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 35.01%. Comparing base (572f309) to head (1e5ca3e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...pinpoint/profiler/micrometer/MicrometerModule.java 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11972      +/-   ##
============================================
- Coverage     35.01%   35.01%   -0.01%     
+ Complexity    10972    10967       -5     
============================================
  Files          3824     3824              
  Lines         91770    91774       +4     
  Branches       9705     9706       +1     
============================================
- Hits          32135    32131       -4     
- Misses        56967    56979      +12     
+ Partials       2668     2664       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit 4733cc2 into pinpoint-apm:master Jan 17, 2025
3 checks passed
@minwoo-jung minwoo-jung self-requested a review January 17, 2025 07:16
Copy link
Member

@minwoo-jung minwoo-jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@emeroad emeroad deleted the #11971_micrometer branch January 17, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants