add gating for review icon

pinterest · Feb 5, 2025 · 24704eb · 24704eb
1 parent e784a5b
commit 24704eb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/querybook/webapp/components/EnvironmentAppSidebar/EntitySidebar.tsx b/querybook/webapp/components/EnvironmentAppSidebar/EntitySidebar.tsx
@@ -9,7 +9,6 @@ import { SearchContainer } from 'components/Search/SearchContainer';
 import { UserMenu } from 'components/UserMenu/UserMenu';
 import { ComponentType, ElementType } from 'const/analytics';
 import { trackClick } from 'lib/analytics';
-import { usePeerReview } from 'lib/peer-review/config';
 import { queryMetastoresSelector } from 'redux/dataSources/selector';
 import { currentEnvironmentSelector } from 'redux/environment/selector';
 import { IconButton } from 'ui/Button/IconButton';
@@ -19,6 +18,7 @@ import { Entity } from './types';
 
 import './EntitySidebar.scss';
 import { QueryReviewButton } from 'components/QueryReviewsNavigator/QueryReviewButton';
+import { hasEnabledPeerReviewEngineSelector } from 'redux/queryReview/selector';
 
 interface IEntitySidebarProps {
     selectedEntity: Entity;
@@ -29,7 +29,9 @@ export const EntitySidebar: React.FunctionComponent<IEntitySidebarProps> =
     React.memo(({ selectedEntity, onSelectEntity }) => {
         const environment = useSelector(currentEnvironmentSelector);
         const queryMetastores = useSelector(queryMetastoresSelector);
-        const { isEnabled: isPeerReviewEnabled } = usePeerReview();
+        const hasEnabledPeerReviewEngine = useSelector(
+            hasEnabledPeerReviewEngineSelector
+        );
 
         return (
             <div className="EntitySidebar">
@@ -156,7 +158,7 @@ export const EntitySidebar: React.FunctionComponent<IEntitySidebarProps> =
                         }}
                         active={selectedEntity === 'execution'}
                     />
-                    {isPeerReviewEnabled && (
+                    {hasEnabledPeerReviewEngine && (
                         <QueryReviewButton
                             active={selectedEntity === 'review'}
                             onClick={() => {

diff --git a/querybook/webapp/redux/queryReview/selector.ts b/querybook/webapp/redux/queryReview/selector.ts
@@ -1,6 +1,7 @@
 import { createSelector } from 'reselect';
 
 import { IStoreState } from '../store/types';
+import { queryEngineSelector } from 'redux/queryEngine/selector';
 
 const selectQueryReviewState = (state: IStoreState) => state.queryReview;
 
@@ -33,3 +34,11 @@ export const selectErrorAssignedReviews = createSelector(
     selectQueryReviewState,
     (queryReview) => queryReview.errorAssignedReviews
 );
+
+export const hasEnabledPeerReviewEngineSelector = createSelector(
+    queryEngineSelector,
+    (queryEngines): boolean =>
+        queryEngines.some((engine) =>
+            Boolean(engine?.feature_params?.peer_review)
+        )
+);