Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCTPTransport OnClose test #2864

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix SCTPTransport OnClose test #2864

merged 1 commit into from
Aug 13, 2024

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Aug 12, 2024

We need to close both the ends here for all the goroutines to complete.

The corresponding commit in v3 is here: 484d89a

@sukunrt sukunrt requested a review from Sean-Der August 12, 2024 18:46
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (3aab035) to head (0805116).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2864      +/-   ##
==========================================
+ Coverage   78.85%   78.90%   +0.04%     
==========================================
  Files          89       89              
  Lines        8452     8452              
==========================================
+ Hits         6665     6669       +4     
+ Misses       1299     1296       -3     
+ Partials      488      487       -1     
Flag Coverage Δ
go 80.46% <ø> (+0.05%) ⬆️
wasm 65.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sukunrt sukunrt merged commit 1e76a83 into master Aug 13, 2024
16 checks passed
@sukunrt sukunrt deleted the fix-sctp-test branch August 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants