Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more data from webrtc stats #2916

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Support more data from webrtc stats #2916

merged 1 commit into from
Oct 5, 2024

Conversation

aalekseevx
Copy link
Member

Description

Parse more webrtc stats according to https://www.w3.org/TR/webrtc-stats/

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.12%. Comparing base (5637661) to head (dccfbb2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
icetransportstate.go 53.33% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2916      +/-   ##
==========================================
+ Coverage   78.99%   79.12%   +0.12%     
==========================================
  Files          89       89              
  Lines        8541     8564      +23     
==========================================
+ Hits         6747     6776      +29     
+ Misses       1303     1302       -1     
+ Partials      491      486       -5     
Flag Coverage Δ
go 80.68% <53.33%> (+0.13%) ⬆️
wasm 64.47% <23.33%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

Sean-Der commented Oct 3, 2024

LGTM! Mind fixing the lints and good to merge :)

@aalekseevx aalekseevx force-pushed the more-stats branch 3 times, most recently from 56bc871 to 3fd2ab5 Compare October 3, 2024 17:32
@aalekseevx
Copy link
Member Author

@Sean-Der, I think he's happy now 👍

@aalekseevx aalekseevx merged commit 891d96f into master Oct 5, 2024
17 of 18 checks passed
@aalekseevx aalekseevx deleted the more-stats branch October 5, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants