Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stage Plugins] Implement ListStageCommands() in pipedapi #5534

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Feb 3, 2025

What this PR does:

  • Implement ListStageCommands() in pipedapi
  • Implement ListStageCommands() in commandstore as backend

In the next PR, I'll implement ReportCommandsHandled() to report stage commands as completed in the scheduler.

Why we need it:

Which issue(s) this PR fixes:

Part of #5367
Follows #5521

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.

Project coverage is 26.46%. Comparing base (4411ffb) to head (4107029).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/apistore/commandstore/store.go 42.42% 19 Missing ⚠️
pkg/app/pipedv1/cmd/piped/grpcapi/plugin_api.go 0.00% 10 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5534      +/-   ##
==========================================
+ Coverage   26.43%   26.46%   +0.02%     
==========================================
  Files         465      465              
  Lines       49858    49878      +20     
==========================================
+ Hits        13182    13200      +18     
- Misses      35621    35624       +3     
+ Partials     1055     1054       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants