-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment trace list API to web service and mock response #5580
Conversation
Signed-off-by: khanhtc1202 <[email protected]>
cc @hongky-1994 |
Signed-off-by: khanhtc1202 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay to start from here.
IMO, we should consider which trace the deployment triggered by the web UI should belong to.
@khanhtc1202 |
Signed-off-by: khanhtc1202 <[email protected]>
Sorry I could not get your point, could you please explain this 🙏 @Warashi |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5580 +/- ##
==========================================
- Coverage 26.34% 26.29% -0.05%
==========================================
Files 467 467
Lines 50114 50198 +84
==========================================
Hits 13202 13202
- Misses 35857 35941 +84
Partials 1055 1055 ☔ View full report in Codecov by Sentry. |
The deployment triggered by the Web UI is not caused by application code modification. IMO, we should handle this kind of deployment differently from the deployment triggered by the EventWatcher's git commit, which is caused by application code modification. |
I got your point, let's think about it later, the first release for deployment trace feature should focus on deployment which is caused by application code midification 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
as title
Why we need it:
Mock the data response for frontend dev to start deployment trace UI development 💪
Which issue(s) this PR fixes:
Part of #5444
Does this PR introduce a user-facing change?: