Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment trace list API to web service and mock response #5580

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

Mock the data response for frontend dev to start deployment trace UI development 💪

Which issue(s) this PR fixes:

Part of #5444

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202
Copy link
Member Author

cc @hongky-1994

Warashi
Warashi previously approved these changes Feb 18, 2025
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to start from here.

IMO, we should consider which trace the deployment triggered by the web UI should belong to.

@ffjlabo
Copy link
Member

ffjlabo commented Feb 18, 2025

@khanhtc1202
CI test/go is failed 👀

Signed-off-by: khanhtc1202 <[email protected]>
@khanhtc1202
Copy link
Member Author

khanhtc1202 commented Feb 18, 2025

Okay to start from here.

IMO, we should consider which trace the deployment triggered by the web UI should belong to.

Sorry I could not get your point, could you please explain this 🙏 @Warashi

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.

Project coverage is 26.29%. Comparing base (9bfc827) to head (33c185c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/server/grpcapi/web_api.go 0.00% 82 Missing ⚠️
...g/app/server/service/webservice/service.pb.auth.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5580      +/-   ##
==========================================
- Coverage   26.34%   26.29%   -0.05%     
==========================================
  Files         467      467              
  Lines       50114    50198      +84     
==========================================
  Hits        13202    13202              
- Misses      35857    35941      +84     
  Partials     1055     1055              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi
Copy link
Contributor

Warashi commented Feb 18, 2025

Okay to start from here.
IMO, we should consider which trace the deployment triggered by the web UI should belong to.

Sorry I could not get your point, could you please explain this 🙏 @Warashi

The deployment triggered by the Web UI is not caused by application code modification. IMO, we should handle this kind of deployment differently from the deployment triggered by the EventWatcher's git commit, which is caused by application code modification.

@khanhtc1202
Copy link
Member Author

The deployment triggered by the Web UI is not caused by application code modification. IMO, we should handle this kind of deployment differently from the deployment triggered by the git commit, which is caused by application code modification.

I got your point, let's think about it later, the first release for deployment trace feature should focus on deployment which is caused by application code midification 👍

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) February 18, 2025 06:40
@khanhtc1202
Copy link
Member Author

@Warashi @ffjlabo please recheck 👀

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit ec324c8 into master Feb 18, 2025
16 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the mock-deployment-trace-api branch February 18, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants