UI for deployment traces feature #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kypham <[email protected]>
hongky-1994
requested review from
khanhtc1202,
ffjlabo,
t-kikuc and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5594 +/- ##
=======================================
Coverage 26.25% 26.25%
=======================================
Files 472 472
Lines 50388 50388
=======================================
Hits 13230 13230
Misses 36097 36097
Partials 1061 1061 ☔ View full report in Codecov by Sentry. |
khanhtc1202
approved these changes
Feb 23, 2025
t-kikuc
reviewed
Feb 25, 2025
Comment on lines
+177
to
+187
| <Link | ||
| component={RouterLink} | ||
| className={clsx(classes.link, { | ||
| [classes.activeLink]: | ||
| location.pathname === PAGE_PATH_DEPLOYMENT_TRACE, | ||
| })} | ||
| color="inherit" | ||
| to={PAGE_PATH_DEPLOYMENT_TRACE} | ||
| > | ||
| Deployment Traces | ||
| </Link> |
There was a problem hiding this comment.
Just a confirmation. Is it OK to show this button after the next minor release?
Or hide it until some point? (although '/deployment-traces' path will be valid)
There was a problem hiding this comment.
Yes, we should target next minor as release version for this. Along with some other update like form to add application for plugin piped 👀
t-kikuc
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
deployment-tracesList
Deployment-trace-item
Show commit message
Show deployments related
Why we need it:
Which issue(s) this PR fixes:
Part of #5444
Does this PR introduce a user-facing change?: