Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opgg provider #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix opgg provider #33

wants to merge 2 commits into from

Conversation

rincew1nd
Copy link
Contributor

Fetching of item builds from op.gg.
Haven't tested it in-game, but should work properly.

Chobocharles
Chobocharles reviewed Mar 1, 2021
View reviewed changes
Copy link

@Chobocharles Chobocharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why are each of the variables and objects not explicitly defined by type? Just a coding preference?

@pipe01
Copy link
Owner

pipe01 commented Mar 1, 2021

Yeah it's just preference, I usually write all my code using vars for all types except primitives

@Chobocharles
Copy link

Ah, okie dokes, thank you :)

@rincew1nd
Copy link
Contributor Author

rincew1nd commented Mar 10, 2021 •
edited
Loading

Yeah. like @pipe01 said, it's just a coding style that i'm using (for work and hobby projects). I'm explicitly defining types when boxing could fail or compiler could not automatically resolve a type.

Also i believe that this PR is outdated as hell, cause markdown could be changed many times for past 2 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chobocharles Chobocharles Chobocharles left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rincew1nd @pipe01 @Chobocharles