-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sol v0.8 #21
base: master
Are you sure you want to change the base?
Sol v0.8 #21
Conversation
Should I expect the CI workflow to run in this PR? I did a quick check of permissions and it seems it should be running. |
.github/workflows/ci.yml
Outdated
@@ -0,0 +1,20 @@ | |||
name: "CI" | |||
on: | |||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a typo? usually i see this as on: [push]
fix workflow typo
@pipermerriam I'm guessing we're not seeing the CI runs because the PR is cross-repository. Probably some github policy. When I make PRs onto our fork of the repo, CI works fine. If you want to see the CI run before merging, you'll probably have to pull this branch, push up a local copy, and open a new PR. |
According to github, you should be able to "approve and run" @pipermerriam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets see if this enables the workflow?
Maybe try to rename |
CI works fine. It's just disabled for outside contributors. |
This PR does the following: