Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sol v0.8 #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Sol v0.8 #21

wants to merge 5 commits into from

Conversation

RyanRHall
Copy link

@RyanRHall RyanRHall commented Oct 20, 2021

This PR does the following:

  • upgrades the DateTime contract to sol v0.8
  • introduces brownie as a dependency for running tests locally
  • adds a CI workflow to hopefully make future changes easier to manage

@pipermerriam
Copy link
Owner

Should I expect the CI workflow to run in this PR? I did a quick check of permissions and it seems it should be running.

@@ -0,0 +1,20 @@
name: "CI"
on:
push:
Copy link

@lightclient lightclient Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a typo? usually i see this as on: [push]

@RyanRHall
Copy link
Author

@pipermerriam I'm guessing we're not seeing the CI runs because the PR is cross-repository. Probably some github policy. When I make PRs onto our fork of the repo, CI works fine.

If you want to see the CI run before merging, you'll probably have to pull this branch, push up a local copy, and open a new PR.

@RyanRHall
Copy link
Author

Copy link
Owner

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets see if this enables the workflow?

@lightclient
Copy link

Maybe try to rename ci.yml to ci.yaml?

@RyanRHall
Copy link
Author

Maybe try to rename ci.yml to ci.yaml?

CI works fine. It's just disabled for outside contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants