Use more meaningful command name internally

piroor · Oct 30, 2023 · 31f7d2e · 31f7d2e
1 parent 5b49648
commit 31f7d2e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/webextensions/background/commands.js b/webextensions/background/commands.js
@@ -1027,10 +1027,10 @@ SidebarConnection.onMessage.addListener(async (windowId, message) => {
       performTabsDragDropWithMessage(message);
       break;
 
-    case Constants.kCOMMAND_TOGGLE_MUTED: {
+    case Constants.kCOMMAND_TOGGLE_MUTED_FROM_SOUND_BUTTON: {
       await Tab.waitUntilTracked(message.tabId);
       const root = Tab.get(message.tabId);
-      log('toggle muted state: ', message, root);
+      log('toggle muted state from sound button: ', message, root);
       if (!root)
         break;
 

diff --git a/webextensions/common/constants.js b/webextensions/common/constants.js
@@ -85,7 +85,7 @@ export const kCOMMAND_AUTODETECT_DUPLICATED_TAB_DETECTION_DELAY = 'treestyletab:
 export const kCOMMAND_TEST_DUPLICATED_TAB_DETECTION             = 'treestyletab:test-duplicated-tab-detection';
 
 export const kCOMMAND_ACTIVATE_TAB            = 'treestyletab:activate-tab';
-export const kCOMMAND_TOGGLE_MUTED            = 'treestyletab:toggle-muted';
+export const kCOMMAND_TOGGLE_MUTED_FROM_SOUND_BUTTON = 'treestyletab:toggle-muted-from-sound-button';
 export const kCOMMAND_PERFORM_TABS_DRAG_DROP  = 'treestyletab:perform-tabs-drag-drop';
 export const kCOMMAND_BLOCK_USER_OPERATIONS   = 'treestyletab:block-user-operations';
 export const kCOMMAND_UNBLOCK_USER_OPERATIONS = 'treestyletab:unblock-user-operations';

diff --git a/webextensions/sidebar/mouse-event-listener.js b/webextensions/sidebar/mouse-event-listener.js
@@ -728,7 +728,7 @@ async function handleDefaultMouseUpOnTab({ lastMousedown, tab, event } = {}) {
            EventUtils.isEventFiredOnSoundButton(event)) {
     log('clicked on sound button');
     BackgroundConnection.sendMessage({
-      type:  Constants.kCOMMAND_TOGGLE_MUTED,
+      type:  Constants.kCOMMAND_TOGGLE_MUTED_FROM_SOUND_BUTTON,
       tabId: tab.id
     });
   }