Prefer to use configs.autoAttachOnNewTabCommand

piroor · Jan 16, 2024 · 5e52a43 · 5e52a43
1 parent 4bbf936
commit 5e52a43
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/webextensions/sidebar/mouse-event-listener.js b/webextensions/sidebar/mouse-event-listener.js
@@ -1070,11 +1070,14 @@ function onNewTabActionSelect(item, event) {
         break;
       case 'child':
         const hints = new Set([
-          configs.autoAttachOnNewTabCommand,
           configs.autoAttachOnNewTabButtonMiddleClick,
           configs.autoAttachOnNewTabButtonAccelClick,
         ]);
-        if (hints.has(Constants.kNEWTAB_OPEN_AS_CHILD_TOP))
+        if (configs.autoAttachOnNewTabCommand == Constants.kNEWTAB_OPEN_AS_CHILD_TOP)
+          action = Constants.kNEWTAB_OPEN_AS_CHILD_TOP;
+        else if (configs.autoAttachOnNewTabCommand == Constants.kNEWTAB_OPEN_AS_CHILD_END)
+          action = Constants.kNEWTAB_OPEN_AS_CHILD_END;
+        else if (hints.has(Constants.kNEWTAB_OPEN_AS_CHILD_TOP))
           action = Constants.kNEWTAB_OPEN_AS_CHILD_TOP;
         else if (hints.has(Constants.kNEWTAB_OPEN_AS_CHILD_END))
           action = Constants.kNEWTAB_OPEN_AS_CHILD_END;