Suppress missing active tab error

piroor · Feb 2, 2024 · 89c64ca · 89c64ca
1 parent 1022cb3
commit 89c64ca
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/webextensions/common/tst-api.js b/webextensions/common/tst-api.js
@@ -1245,13 +1245,20 @@ async function getTabFromWrongId({ id, activeWindow, sender }) {
     id = id.id;
   let query   = String(id).toLowerCase();
   let baseTab = Tab.getActiveTab(activeWindow.id);
+
+  // this sometimes happen when the active tab was detached from the window
+  if (!baseTab)
+    return null;
+
   const nonActiveTabMatched = query.match(/^([^-]+)-of-(.+)$/i);
   if (nonActiveTabMatched) {
     query = nonActiveTabMatched[1];
     id    = nonActiveTabMatched[2];
     if (/^\d+$/.test(id))
       id = parseInt(id);
     baseTab = Tab.get(id) || Tab.getByUniqueId(id);
+    if (!baseTab)
+      return null;
   }
   switch (query) {
     case 'active':