Don't show tab preview in the sidebar after the cursor left from the

sidebar area
piroor · Dec 11, 2024 · 95b8c2f · 95b8c2f
1 parent a114fab
commit 95b8c2f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/webextensions/resources/module/tab-preview-frame.js b/webextensions/resources/module/tab-preview-frame.js
@@ -336,6 +336,8 @@ try{
                panel.dataset.tabId != message.previewTabId)) {
             if (message?.logging)
               console.log(`hide tab preview(${message.previewTabId}): already hidden, nothing to do `, message.timestamp);
+            if (!panel && !message.previewTabId) // on initial case
+              lastTimestamp = message.timestamp;
             return;
           }
           if (message.timestamp < lastTimestamp) {

diff --git a/webextensions/sidebar/tab-preview-tooltip.js b/webextensions/sidebar/tab-preview-tooltip.js
@@ -405,12 +405,13 @@ async function waitUntilPreviewFrameLoadedIntoTab(tabId) {
 
 
 async function sendInSidebarTabPreviewMessage(message) {
+  const startAt = message.startAt || Date.now();
   log(`sendInSidebarTabPreviewMessage(${message.type}})`);
   if (typeof message.previewURL == 'function')
     message.previewURL = await message.previewURL();
   await TabPreviewFrame.handleMessage({
+    timestamp: startAt,
     ...message,
-    timestamp: Date.now(),
     windowId: TabsStore.getCurrentWindowId(),
     animation: shouldApplyAnimation(),
     logging: configs.logFor['sidebar/tab-preview-tooltip'] && configs.debug,
@@ -559,17 +560,22 @@ onTabSubstanceLeave = EventUtils.wrapWithErrorHandler(onTabSubstanceLeave);
 
 
 browser.tabs.onActivated.addListener(activeInfo => {
+  const startAt = Date.now();
+
   if (activeInfo.windowId != TabsStore.getCurrentWindowId())
     return;
 
   sendInSidebarTabPreviewMessage({
     type: 'treestyletab:hide-tab-preview',
+    timestamp: startAt,
   });
   sendTabPreviewMessage(activeInfo.tabId, {
     type: 'treestyletab:hide-tab-preview',
+    timestamp: startAt,
   });
   sendTabPreviewMessage(activeInfo.previousTabId, {
     type: 'treestyletab:hide-tab-preview',
+    timestamp: startAt,
   });
 });
 
@@ -615,14 +621,19 @@ Sidebar.onReady.addListener(() => {
 });
 
 document.querySelector('#tabbar').addEventListener('mouseleave', async () => {
-  log('mouse is left from the tab bar');
+  const startAt = Date.now();
+  log('mouse is left from the tab bar ', startAt);
+
+  hoveringTabIds.clear();
 
   sendInSidebarTabPreviewMessage({
     type: 'treestyletab:hide-tab-preview',
+    timestamp: startAt,
   });
 
   const activeTab = Tab.getActiveTab(TabsStore.getCurrentWindowId());
   sendTabPreviewMessage(activeTab.id, {
     type: 'treestyletab:hide-tab-preview',
+    timestamp: startAt,
   });
 });