make acceptance tests less error prone when changes in hello-tile occur #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crhntr
added a commit
that referenced
this pull request
Jan 12, 2024
I am working on a fix for this here: #462
|
the test failed and I have a more stable fix for that error here: #462 |
crhntr
changed the title
crhntr
added
the
tas-slingshots
crhntr
added a commit
that referenced
this pull request
Jan 12, 2024
I am working on a fix for this here: #462
pvaramballypivot
pushed a commit
that referenced
this pull request
Jan 12, 2024
I am working on a fix for this here: #462
crhntr
force-pushed
the
fix-flakey-acceptance-tests
branch
7 times, most recently
from
416a434 to
a874b05
Compare
also: - add test script - use exec instead of go-git - fix shellcheck issue remove unused submodule fix git author config in tests add gitkeep to release dirs
crhntr
force-pushed
the
fix-flakey-acceptance-tests
branch
from
a874b05 to
bc09b47
Compare
pvaramballypivot
approved these changes
Jan 16, 2024
notrepo05
pushed a commit
to notrepo05/kiln
that referenced
this pull request
Jan 23, 2024
I am working on a fix for this here: pivotal-cf#462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes each test use a temporary tile source directory and the source is copied from simple directories. Git is initialized for each test. Most changes to crhntr/hello-tile source files will no longer break kiln tests.
In both of these cases, the tests will fail with a clear error message.