Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a without-download flag to update-stemcell to skip release downloads #519

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add a without-download flag to update-stemcell to skip release downloads #519

wants to merge 4 commits into from

Conversation

davewalter
Copy link
Contributor

This PR re-applies the changes from #493 with the addition of a without-download
flag to control the behaviour.

@davewalter davewalter changed the title Adds a without-download flag to update-stemcell to skip release downloads Add a without-download flag to update-stemcell to skip release downloads Jan 11, 2025
drich10
drich10 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@drich10 drich10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one suggestion to add a short flag for the new option

internal/commands/update_stemcell.go Outdated Show resolved Hide resolved
@davewalter davewalter force-pushed the restore-update-stemcell-without-download-flag branch 2 times, most recently from 81de206 to 3b5aea2 Compare January 14, 2025 00:40
@davewalter davewalter requested a review from dlinsley January 14, 2025 15:48
@davewalter davewalter force-pushed the restore-update-stemcell-without-download-flag branch from 3b5aea2 to b407b35 Compare January 14, 2025 20:57
@davewalter davewalter requested a review from dlinsley January 14, 2025 20:57
dlinsley
dlinsley approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@dlinsley dlinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for improving the logging too!

@davewalter davewalter force-pushed the restore-update-stemcell-without-download-flag branch from b407b35 to 8040db0 Compare January 17, 2025 02:20
@davewalter davewalter requested a review from dlinsley January 17, 2025 02:21
@davewalter davewalter force-pushed the restore-update-stemcell-without-download-flag branch from 8040db0 to 186630c Compare January 17, 2025 02:29
@davewalter
Copy link
Contributor Author

@dlinsley I've added some acceptance tests to cover the --update-releases and--without-download flags for update-release and update-stemcell. Could you please take another look?

@davewalter davewalter force-pushed the restore-update-stemcell-without-download-flag branch from 186630c to 8f3a440 Compare January 17, 2025 02:39
@davewalter
Add a without-download flag to update-stemcell
0ffc228 
Allows Kiln to skip downloading a release if the remote source can
provide the SHA1 for the release tarball.
@davewalter
Add acceptance test coverage for new features
3140b09 
* update-release --without-download
* update-stemcell --without-download
* updating_stemcell --update-releases
@davewalter davewalter force-pushed the restore-update-stemcell-without-download-flag branch from 8f3a440 to 3140b09 Compare January 17, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlinsley dlinsley dlinsley approved these changes

@drich10 drich10 drich10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davewalter @drich10 @dlinsley