Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sends helpful error when metedata has multiple stemcell types #678

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

wayneadams
Copy link
Contributor

  • Add checkForSingleStemcellType function to validate stemcell selection
  • Update getLatestStemcell to track all unique stemcell types
  • Add test case to verify error handling for multiple stemcell types

Authored by: Wayne Adams [email protected]

Copy link
Member

@drich10 drich10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - minor comment for using some of the "newer" go functionality.

Food for thought, that isn't in scope of this PR. Would it make sense to extend choice in this scenario so that folks could pick an OS/slug as part of invoking the om command?

download_clients/pivnet_client.go Outdated Show resolved Hide resolved
@wayneadams wayneadams requested a review from drich10 November 26, 2024 17:19
- Add checkForSingleStemcellType function to validate stemcell selection
- Update getLatestStemcell to track all unique stemcell types
- Add test case to verify error handling for multiple stemcell types

Authored by: Wayne Adams <[email protected]>
@wayneadams wayneadams force-pushed the download-product-failure branch from f4dc68a to 35ac8ee Compare November 27, 2024 16:21
@wayneadams wayneadams merged commit ecedee0 into main Nov 27, 2024
1 check passed
@wayneadams wayneadams deleted the download-product-failure branch November 27, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants